147 add support for ethers v6 #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add-support-for-ethers-v6
…all chains in one URL
MMujtabaRoohani-BlockApex
force-pushed
the
147-add-support-for-ethers-v6
branch
from
abd087f to
91dc1dc
Compare
MMujtabaRoohani-BlockApex
force-pushed
the
147-add-support-for-ethers-v6
branch
from
91dc1dc to
88f42e4
Compare
|
@0xslipk any luck reviewing the changes? I noticed that there were some real RPC calls being made during tests, I have made necessary changes to mock them and have added some tests as well to achieve near 100% code coverage. |
|
@0xslipk would love your input on this 🙏 |
|
@0xslipk waiting for your response, want to know if you will be reviewing this shortly or if you have abandoned this project or are you looking for collaborators to manage this effectively? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current framework depends on ethers v5 that is superseded v6 since more than 2 years. ethers v5 lacks batched JsonRpc calls, error handling from newer rpc endpoints and several syntax and other improvements offered by v6.
Issue Number: 147
What is the new behavior?
The newer version supports ethers v6
Does this PR introduce a breaking change?
There are several breaking changes from ethers v5 to v6 that are documented in this migration guide.